ejabberd - Comments for "'Static' rosters"

Legoscia found a bug. Try new version

mfoss — Tue, 19 Jun 2007 21:18:25 +0000

Legoscia found a bug. I've updated the code on my initial comment. You can see that at the end there are now several "".

Atoms → strings

legoscia — Tue, 19 Jun 2007 16:20:41 +0000

badlop wrote:

% http://www.xmpp.org/rfcs/rfc3921.html#sub
check_rosterchange({xmlelement, "presence", Attrs, _}) ->
	case xml:get_attr_s("type", Attrs) of
		subscribe -> true;
		subscribed -> true;
		unsubscribe -> true;
		unsubscribed -> true;
		_ -> false
	end.

Shouldn't those be strings?

Thanks a lot!

doozer — Tue, 19 Jun 2007 15:29:02 +0000

Hi badlop,

many thanks for providing this filter! It works great!

There is still a small problem: Though all packets regarding the roster are filtered, it is still possible to add an item to an user's roster (checked via Web-Interface). Any other operation (deletion, modification etc.) is blocked successfully.

Try this small mod_filterroster.erl

mfoss — Tue, 19 Jun 2007 08:54:10 +0000

Try this small mod_filterroster.erl module. It drops all the XMPP packets that are typically used to modify the roster. Note that it drops packets even from admins, and for all vhosts.

Open a file called mod_filterroster.erl and put the content.
Compile the .erl into a .beam. You need full Erlang/OTP installation, it doesn't care which operating system:
```
$ erlc mod_filterroster.erl
./mod_filterroster.erl:2: Warning: behaviour gen_mod undefined
```
Copy the resulting .beam file to the directory where all the other ejabberd .beam files are.
Configure ejabberd to enable this module. For example on ejabberd.cfg:
```
{modules, [
  ...
  {mod_filterroster, []},
  ...
]}.
```

Here is the source code:

-module(mod_filterroster).
-behaviour(gen_mod).
-export([start/2, stop/1, filter/1]).

%-include("jlib.hrl").
-define(NS_ROSTER,       "jabber:iq:roster").
-record(iq, {id = "",
	     type,
	     xmlns = "",
	     lang = "",
	     sub_el}).

start(_Host, _Opts) ->
    ejabberd_hooks:add(filter_packet, global, ?MODULE, filter, 10).

stop(_Host) ->
    ejabberd_hooks:delete(filter_packet, global, ?MODULE, filter, 10).

filter(drop) -> drop;
filter({_From, _To, Packet} = Input) ->
	case check_rosterchange(Packet) of
		false -> Input;
		true -> drop
    end.

% http://www.xmpp.org/rfcs/rfc3921.html#roster
check_rosterchange({xmlelement, "iq", _, _} = Packet) ->
	IQ = jlib:iq_query_info(Packet),
	case catch #iq{type = set, xmlns = ?NS_ROSTER} = IQ of
		{'EXIT', _} -> false;
		_ -> true
	end;
	
% http://www.xmpp.org/rfcs/rfc3921.html#sub
check_rosterchange({xmlelement, "presence", Attrs, _}) ->
	case xml:get_attr_s("type", Attrs) of
		"subscribe" -> true;
		"subscribed" -> true;
		"unsubscribe" -> true;
		"unsubscribed" -> true;
		_ -> false
	end.

ejabberd - Comments for "&#039;Static&#039; rosters"

Legoscia found a bug. Try new version

Atoms → strings

Thanks a lot!

Try this small mod_filterroster.erl

ejabberd - Comments for "'Static' rosters"