ejabberd - Comments for "Ejabberd crash when using cleaning rooms using mod_muc_admin"

Thanks! we are eager to start

marcelo.manrique — Tue, 02 Jan 2018 18:39:38 +0000

Thanks! we are eager to start contributing

I think there aren't written

badlop — Thu, 28 Dec 2017 09:21:12 +0000

I think there aren't written guidelines specific to ejabberd. Basically, try to change only the source code lines strictly required for your changes. Split changes related to different topics in different commits. Indent the code following the emacs standard (well, I use Vim, but try to follow the appearance of the existing code).

In your first push, mention that this is your first contribution, and request any suggestion to do it better in the future ;)

The second commit

marcelo.manrique — Fri, 22 Dec 2017 17:57:46 +0000

The second commit (https://github.com/processone/ejabberd/commit/5e4c547856de6624e4012eb3bf...) seems to have fixed the issue. Thanks!

We also want to start contributing with the ejabberd community pushing some corrections. Where can we find guidelines to do so?

The second commit

marcelo.manrique — Fri, 22 Dec 2017 17:57:00 +0000

The second commit (https://github.com/processone/ejabberd/commit/5e4c547856de6624e4012eb3bf...) seems to have fixed the issue. Thanks!

We also want to start contributing with the ejabberd community pushing some corrections. Where can we find guidelines to do so?

I can reproduce that crash,

badlop — Thu, 21 Dec 2017 16:01:59 +0000

I can reproduce that crash, and fixed it in this recent commit:
https://github.com/processone/ejabberd/commit/50b19b47e023180f48878620a5...