ejabberd - Comments for "s2s stop work after upgrade to ejabberd 2.1-RC2"

> Any "side effects" of this

mfoss — Thu, 22 Oct 2009 14:40:19 +0000

> Any "side effects" of this patch ?

No. This patch doesn't have bad effects. If S2S works well for you, you can continue until new version is published.

> If ejabberd compiled with "new" version Erlang/OTP it work without this patch ?

Right. You can have:

ejabberd 2.1.0-rc2 + patch, compiled with Erlang/OTP R12B-5 or older
ejabberd 2.1.0-rc2, compiled with Erlang/OTP R13B or newer

thaks!

evadim — Thu, 22 Oct 2009 06:34:59 +0000

s2s work now. If ejabberd compiled with "new" version Erlang/OTP it work without this patch ? Any "side effects" of this patch ?

Try this small fix

mfoss — Wed, 21 Oct 2009 21:14:05 +0000

I found the problem. It affects s2s out connections in ejabberd 2.1.0-rc2 when using Erlang/OTP R12 or older.

You can fix easily, only need to remove one line:

--- src/ejabberd_s2s_out.erl
+++ src/ejabberd_s2s_out.erl
@@ -272,7 +272,6 @@ open_socket2(Type, Addr, Port) ->
     case (catch ejabberd_socket:connect(Addr, Port,
                                        [binary, {packet, 0},
                                         {send_timeout, ?TCP_SEND_TIMEOUT},
-                                         {send_timeout_close, true},
                                         {active, false}, Type | SockOpts],
                                        Timeout)) of
        {ok, _Socket} = R -> R;

If you install rc2 again and you try this solution, please tell me if that solves the problem.

downgrade to RC1 solve this

evadim — Wed, 21 Oct 2009 20:15:13 +0000

downgrade to RC1 solve this issue